Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent comments between 2 templates of unchecked(). #4519

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

xkszltl
Copy link
Contributor

@xkszltl xkszltl commented Feb 19, 2023

This comment is unrelated to having T in tparam or not.
Probably a typo.
Copied the correct one here.

Resolve #4518

This comment is unrelated to having T in tparam or not.
Probably a typo.
Copied the correct one here.

Resolve pybind#4518
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this code, but that's a pretty obvious oversight. Thanks for catching and fixing!

@rwgk rwgk merged commit a19daea into pybind:master Feb 20, 2023
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 20, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Feb 20, 2023
henryiii pushed a commit that referenced this pull request Feb 24, 2023
This comment is unrelated to having T in tparam or not.
Probably a typo.
Copied the correct one here.

Resolve #4518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Inaccurate doc on unchecked().
2 participants