Revert "Go back to CMake 3.25.2 (#4496)"

[rwgk]

This reverts PR #4496 (b8f2855).

CMake bug report (suspected regression): https://gitlab.kitware.com/cmake/cmake/-/issues/24398

Description

Suggested changelog entry:

[bradking]

Add a preceding commit with this patch to get more verbose information about the connection failure:

diff --git a/tools/FindCatch.cmake b/tools/FindCatch.cmake
index 57bba58b..ef120bc8 100644
--- a/tools/FindCatch.cmake
+++ b/tools/FindCatch.cmake
@@ -36,10 +36,16 @@ endfunction()
 function(_download_catch version destination_dir)
   message(STATUS "Downloading catch v${version}...")
   set(url https://github.com/philsquared/Catch/releases/download/v${version}/catch.hpp)
-  file(DOWNLOAD ${url} "${destination_dir}/catch.hpp" STATUS status)
+  file(DOWNLOAD ${url} "${destination_dir}/catch.hpp" STATUS status LOG log)
   list(GET status 0 error)
   if(error)
-    message(FATAL_ERROR "Could not download ${url}")
+    string(REPLACE "\n" "\n  " log "  ${log}")
+    message(FATAL_ERROR
+      "Could not download URL:\n"
+      "  ${url}\n"
+      "Log:\n"
+      "${log}"
+      )
   endif()
   set(CATCH_INCLUDE_DIR
       "${destination_dir}"

[rwgk]

Thanks a lot @bradking, I'd say your patch is a keeper!

Here is one log:

https://github.com/pybind/pybind11/actions/runs/4138219644/jobs/7154367988

IIUC it reads a bunch of ~1k blocks successfully but then runs into errors:

   ...
    [1330 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1339 bytes data]
    [1057 bytes data]
    [1362 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [731 bytes data]
    [1362 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    [1362 bytes data]
    [1371 bytes data]
    [1371 bytes data]
    SSLRead() return error -50
    Failed receiving HTTP2 data
    SSLWrite() returned error -9806
    Failed sending HTTP2 data
    Connection #1 to host objects.githubusercontent.com left intact

[rwgk]

The curl (in CMake) issue was fixed: https://gitlab.kitware.com/cmake/cmake/-/issues/24398

The fix will be in 3.26.0-rc3

Link to releases (for checking if the rc3 release happened already): https://github.com/Kitware/CMake/releases

[rwgk]

@henryiii This is working now with CMake 3.26.0-rc3. I think it'll be best to also merge @bradking's much more informative reporting of the underlying download error.

[rwgk]

Thanks @henryiii!