Add a new return value policy _clif_automatic
#4343
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Jun 11, 2024
This reverts commit 6d3a0fc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new policy is for making PyCLIF generate pybind11 bindings code.
PyCLIF automatically chooses lifetime management of return values based on the properties of them: https://github.com/google/clif/tree/main/clif/python#pointers-references-and-object-ownership. We would like make the lifetime management of the generated pybind11 code consistent with legacy PyCLIF.
However, this is hard for nested types. For example, for
pair<int, const T*>return values, to be consistent with legacy PyCLIF, we would like to applyreturn_value_policy::copytoint, andreturn_value_policy::referencetoconst T*. This is hard to achieve from top down. With the new return value policy, we can implement this from bottom up.