Add `PYBIND11_SIMPLE_GIL_MANAGEMENT` option (cmake, C++ define) by Chekov2k · Pull Request #4216 · pybind/pybind11

Add option to force the use of the PYPY GIL scoped acquire/release logic to support nested gil access, see pybind#1276 and pytorch/pytorch#83101

SeeChange-CI

authored and

Ralf W. Grosse-Kunstleve

committed

Apply suggestions from code review

henryiii

authored and

Ralf W. Grosse-Kunstleve

committed

Update CMakeLists.txt

henryiii

authored and

Ralf W. Grosse-Kunstleve

committed

docs: update upgrade guide

henryiii

authored and

Ralf W. Grosse-Kunstleve

committed

Update docs/upgrade.rst

henryiii

authored and

Ralf W. Grosse-Kunstleve

committed

All bells & whistles.

Ralf W. Grosse-Kunstleve

committed

Add Reminder to common.h, so that we will not forget to purge `!WITH_THREAD` branches when dropping Python 3.6

Ralf W. Grosse-Kunstleve

committed

New sentence instead of semicolon.

Ralf W. Grosse-Kunstleve

committed

Temporarily pull in snapshot of PR pybind#4246

Ralf W. Grosse-Kunstleve

committed

Add `test_release_acquire`

Ralf W. Grosse-Kunstleve

committed

Add more unit tests for nested gil locking

SeeChange-CI

authored and

Ralf W. Grosse-Kunstleve

committed

Add test_report_builtins_internals_keys

Ralf W. Grosse-Kunstleve

committed

Very minor enhancement: sort list only after filtering.

Ralf W. Grosse-Kunstleve

committed

Revert change in docs/upgrade.rst

Ralf W. Grosse-Kunstleve

committed

Add test_multi_acquire_release_cross_module, while also forcing unique PYBIND11_INTERNALS_VERSION for cross_module_gil_utils.cpp

Ralf W. Grosse-Kunstleve

committed

Hopefully fix apparently new ICC error.

Ralf W. Grosse-Kunstleve

committed

clang-tidy fixes

Ralf W. Grosse-Kunstleve

committed

Workaround for PYPY WIN exitcode None

Ralf W. Grosse-Kunstleve

committed

Revert "Temporarily pull in snapshot of PR pybind#4246 "

Ralf W. Grosse-Kunstleve

committed

Another workaround for PYPY WIN exitcode None

Ralf W. Grosse-Kunstleve

committed

Clean up how the tests are run "run in process" Part 1: uniformity

Ralf W. Grosse-Kunstleve

committed

Clean up how the tests are run "run in process" Part 2: use `@pytest.mark.parametrize` and clean up the naming.

Ralf W. Grosse-Kunstleve

committed

Skip some tests `#if defined(THREAD_SANITIZER)` (tested with TSAN using the Google-internal toolchain).

Ralf W. Grosse-Kunstleve

committed

Run all tests again but ignore ThreadSanitizer exitcode 66 (this is less likely to mask unrelated ThreadSanitizer issues in the future).

Ralf W. Grosse-Kunstleve

committed

bug fix: missing common.h include before using `PYBIND11_SIMPLE_GIL_MANAGEMENT`

Ralf W. Grosse-Kunstleve

committed

if process.exitcode is None: assert t_delta > 9.9

Ralf W. Grosse-Kunstleve

committed

More sophisiticated `_run_in_process()` implementation, clearly reporting `DEADLOCK`, additionally exercised via added `intentional_deadlock()`

Ralf W. Grosse-Kunstleve

committed

Wrap m.intentional_deadlock in a Python function, for `ForkingPickler` compatibility.

Ralf W. Grosse-Kunstleve

committed

Add link to potential solution for WOULD-BE-NICE-TO-HAVE feature.

Ralf W. Grosse-Kunstleve

committed

Add `SKIP_IF_DEADLOCK = True` option, to not pollute the CI results with expected `DEADLOCK` failures while we figure out what to do about them.

Ralf W. Grosse-Kunstleve

committed

Add COPY-PASTE-THIS: gdb ... command (to be used for debugging the detected deadlock)

Ralf W. Grosse-Kunstleve

committed

style: pre-commit fixes

pre-commit-ci[bot]

committed

Do better than automatic pre-commit fixes.

Ralf W. Grosse-Kunstleve

committed

Add `PYBIND11_SIMPLE_GIL_MANAGEMENT` to `pytest_report_header()` (so that we can easily know when harvesting deadlock information from the CI logs).

Ralf W. Grosse-Kunstleve

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `PYBIND11_SIMPLE_GIL_MANAGEMENT` option (cmake, C++ define)#4216

Commits on Oct 30, 2022

Add option to force the use of the PYPY GIL scoped acquire/release logic to support nested gil access, see pybind#1276 and pytorch/pytorch#83101

Apply suggestions from code review

Update CMakeLists.txt

docs: update upgrade guide

Update docs/upgrade.rst

All bells & whistles.

Add Reminder to common.h, so that we will not forget to purge `!WITH_THREAD` branches when dropping Python 3.6

New sentence instead of semicolon.

Temporarily pull in snapshot of PR pybind#4246

Add `test_release_acquire`

Add more unit tests for nested gil locking

Add test_report_builtins_internals_keys

Very minor enhancement: sort list only after filtering.

Revert change in docs/upgrade.rst

Add test_multi_acquire_release_cross_module, while also forcing unique PYBIND11_INTERNALS_VERSION for cross_module_gil_utils.cpp

Hopefully fix apparently new ICC error.

clang-tidy fixes

Workaround for PYPY WIN exitcode None

Revert "Temporarily pull in snapshot of PR pybind#4246 "

Another workaround for PYPY WIN exitcode None

Clean up how the tests are run "run in process" Part 1: uniformity

Clean up how the tests are run "run in process" Part 2: use `@pytest.mark.parametrize` and clean up the naming.

Skip some tests `#if defined(THREAD_SANITIZER)` (tested with TSAN using the Google-internal toolchain).

Run all tests again but ignore ThreadSanitizer exitcode 66 (this is less likely to mask unrelated ThreadSanitizer issues in the future).

bug fix: missing common.h include before using `PYBIND11_SIMPLE_GIL_MANAGEMENT`

if process.exitcode is None: assert t_delta > 9.9

More sophisiticated `_run_in_process()` implementation, clearly reporting `DEADLOCK`, additionally exercised via added `intentional_deadlock()`

Wrap m.intentional_deadlock in a Python function, for `ForkingPickler` compatibility.

Add link to potential solution for WOULD-BE-NICE-TO-HAVE feature.

Add `SKIP_IF_DEADLOCK = True` option, to not pollute the CI results with expected `DEADLOCK` failures while we figure out what to do about them.

Add COPY-PASTE-THIS: gdb ... command (to be used for debugging the detected deadlock)

style: pre-commit fixes

Do better than automatic pre-commit fixes.

Add `PYBIND11_SIMPLE_GIL_MANAGEMENT` to `pytest_report_header()` (so that we can easily know when harvesting deadlock information from the CI logs).