Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix "Enumerations and internal types" example #4034

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

crcrpar
Copy link
Contributor

@crcrpar crcrpar commented Jun 28, 2022

Description

This is a patch for the example mentioned in the title to be built because when building the snippet, I got the build error which includes:

    src/main.cpp:71:60: error: expected ';' at end of declaration
      py::class_<Pet::Attributes> attributes(pet, "Attributes")
                                                               ^
                                                               ;
    1 error generated.

Could you kindly let me know if there's a better change?

docs/classes.rst Outdated Show resolved Hide resolved
@rwgk
Copy link
Collaborator

rwgk commented Jun 28, 2022

Thanks! Looks good. I'm just waiting for the CI to finish. (I cannot imagine what could go wrong, but it's pretty quick.)

@rwgk rwgk merged commit 374a5b0 into pybind:master Jun 28, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 28, 2022
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jun 28, 2022
@crcrpar crcrpar deleted the patch-1 branch June 28, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants