[smart_holder] `type_caster` ODR guard#4022

Merged

rwgk merged 85 commits intopybind:smart_holderfrom rwgk:odr_guard_sh

Jul 21, 2022

+708-29

Commits on Jun 28, 2022

Insert type_caster_odr_guard<> (an empty struct to start with).
Ralf W. Grosse-Kunstleve
committed
Add odr_guard_registry() used in type_caster_odr_guard() default constructor.
Ralf W. Grosse-Kunstleve
committed
Add minimal_real_caster (from PR pybind#3862 ) to test_async, test_buffers
Ralf W. Grosse-Kunstleve
committed
VERY MESSY SNAPSHOT of WIP, this was the starting point for cl/454658864, which has more changes on top.
Ralf W. Grosse-Kunstleve
committed
Restore original test_async, test_buffers from current smart_holder HEAD
Ralf W. Grosse-Kunstleve
committed
Copy from cl/454991845 snapshot Jun 14, 5:08 PM
Ralf W. Grosse-Kunstleve
committed
Cleanup of tests. Systematically insert if (make_caster<T>::translation_unit_local) {
Ralf W. Grosse-Kunstleve
committed
Small simplification of odr_guard_impl()
Ralf W. Grosse-Kunstleve
committed
WIP
Ralf W. Grosse-Kunstleve
committed
Add PYBIND11_SOURCE_FILE_LINE macro.
Ralf W. Grosse-Kunstleve
committed
Replace PYBIND11_TYPE_CASTER_UNIQUE_IDENTIFIER with PYBIND11_TYPE_CASTER_SOURCE_FILE_LINE, baked into PYBIND11_TYPE_CASTER macro.
Ralf W. Grosse-Kunstleve
committed
Add more PYBIND11_DETAIL_TYPE_CASTER_ACCESS_TRANSLATION_UNIT_LOCAL; resolves "unused" warning when compiling test_custom_type_casters.cpp
Ralf W. Grosse-Kunstleve
committed
load_type fixes & follow-on cleanup
Ralf W. Grosse-Kunstleve
committed
Strip ./ from source_file_line
Ralf W. Grosse-Kunstleve
committed
Add new tests to CMakeLists.txt, disable PYBIND11_WERROR
Ralf W. Grosse-Kunstleve
committed
Replace C++17 syntax. Compiles with Debian clang 13 C++11 mode, but fails to link. Trying GitHub Actions anyway to see if there are any platforms that support https://en.cppreference.com/w/cpp/lang…
Ralf W. Grosse-Kunstleve
committed
Show C++ version along with ODR VIOLATION DETECTED message.
Ralf W. Grosse-Kunstleve
committed
Add source_file_line_basename()
Ralf W. Grosse-Kunstleve
committed
Introduce PYBIND11_TYPE_CASTER_ODR_GUARD_ON (but not set automatically).
Ralf W. Grosse-Kunstleve
committed
Minor cleanup.
Ralf W. Grosse-Kunstleve
committed
Set PYBIND11_TYPE_CASTER_ODR_GUARD_ON automatically.
Ralf W. Grosse-Kunstleve
committed
Resolve clang-tidy error.
Ralf W. Grosse-Kunstleve
committed
Compatibility with old compilers.
Ralf W. Grosse-Kunstleve
committed
Fix off-by-one in source_file_line_basename()
Ralf W. Grosse-Kunstleve
committed
Report PYBIND11_INTERNALS_ID & C++ Version from pytest_configure()
Ralf W. Grosse-Kunstleve
committed
Restore use of PYBIND11_WERROR
Ralf W. Grosse-Kunstleve
committed
Move cpp_version_in_use() from cast.h to pybind11_tests.cpp
Ralf W. Grosse-Kunstleve
committed
define PYBIND11_DETAIL_ODR_GUARD_IMPL_THROW_DISABLED true in test_odr_guard_1,2.cpp
Ralf W. Grosse-Kunstleve
committed
IWYU cleanup of detail/type_caster_odr_guard.h
Ralf W. Grosse-Kunstleve
committed
Replace throw err; to resolve clang-tidy error.
Ralf W. Grosse-Kunstleve
committed
Add new header filename to CMakeLists.txt, test_files.py
Ralf W. Grosse-Kunstleve
committed
Experiment: Try any C++17 compiler.
Ralf W. Grosse-Kunstleve
committed
Fix ifdef for pragma GCC diagnostic.
Ralf W. Grosse-Kunstleve
committed
type_caster_odr_guard_impl() cleanup
Ralf W. Grosse-Kunstleve
committed
Move type_caster_odr_guard to type_caster_odr_guard.h
Ralf W. Grosse-Kunstleve
committed
Rename test_odr_guard* to test_type_caster_odr_guard*
Ralf W. Grosse-Kunstleve
committed
Remove comments that are (now) more distracting than helpful.
Ralf W. Grosse-Kunstleve
committed
Mark tu_local_no_data_always_false operator bool as explicit (clang-tidy). See also: https://stackoverflow.com/questions/39995573/when-can-i-use-explicit-operator-bool-without-a-cast
Ralf W. Grosse-Kunstleve
committed
New PYBIND11_TYPE_CASTER_ODR_GUARD_STRICT option (current on by default).
Ralf W. Grosse-Kunstleve
committed
Add test_type_caster_odr_registry_values(), test_type_caster_odr_violation_detected_counter()
Ralf W. Grosse-Kunstleve
committed
Report UNEXPECTED: test_type_caster_odr_guard_2.cpp prevailed (but do not fail).
Ralf W. Grosse-Kunstleve
committed
Apply clang-tidy suggestion.
Ralf W. Grosse-Kunstleve
committed
Attempt to handle valgrind behavior.
Ralf W. Grosse-Kunstleve
committed
Another attempt to handle valgrind behavior.
Ralf W. Grosse-Kunstleve
committed
Yet another attempt to handle valgrind behavior.
Ralf W. Grosse-Kunstleve
committed
Trying a new direction: show compiler info & std for UNEXPECTED: type_caster_odr_violation_detected_count() == 0
Ralf W. Grosse-Kunstleve
committed
compiler_info MSVC fix. num_violations == 0 condition.
Ralf W. Grosse-Kunstleve
committed
assert pybind11_tests.compiler_info is not None
Ralf W. Grosse-Kunstleve
committed
Introduce make_caster_intrinsic<T>, to be able to undo the 2 changes from load_type to load_type<T>. This is to avoid breaking 2 pybind11::detail::load_type() calls found in the wild (Googl…
Ralf W. Grosse-Kunstleve
committed
Add test for stl.h / stl_bind.h mix.
Ralf W. Grosse-Kunstleve
committed
Eliminate need for PYBIND11_DETAIL_TYPE_CASTER_ACCESS_TRANSLATION_UNIT_LOCAL macro.
Ralf W. Grosse-Kunstleve
committed
tu_local_descr with src_loc experiment
Ralf W. Grosse-Kunstleve
committed
clang-tidy suggested fixes
Ralf W. Grosse-Kunstleve
committed

Commits on Jun 29, 2022

Use source_file_line_from_sloc in type_caster_odr_guard_registry
Ralf W. Grosse-Kunstleve
committed
Disable type_caster ODR guard for __INTEL_COMPILER (see comment). Also turn off printf.
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 1, 2022

Add missing include (discovered via google-internal testing).
Ralf W. Grosse-Kunstleve
committed
Work scr_loc into descr
Ralf W. Grosse-Kunstleve
committed
Use TypeCasterType::name.sloc instead of source_file_line.sloc
Ralf W. Grosse-Kunstleve
committed
Fix small oversight (src_loc::here() -> src_loc{nullptr, 0}).
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 2, 2022

Remove PYBIND11_DETAIL_TYPE_CASTER_ACCESS_TRANSLATION_UNIT_LOCAL macro completely.
Ralf W. Grosse-Kunstleve
committed
Remove PYBIND11_TYPE_CASTER_SOURCE_FILE_LINE macro completely. Some small extra cleanup.
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 10, 2022

Merge branch 'smart_holder' into odr_guard_sh
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 11, 2022

Minor tweaks looking at the PR with a fresh eye.
Ralf W. Grosse-Kunstleve
committed
src_loc comments
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 12, 2022

Add new test_descr_src_loc & and fix descr.h concat() src_loc bug discovered while working on the test.
Ralf W. Grosse-Kunstleve
committed
Some more work on source code comments.
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 14, 2022

Merge branch 'smart_holder' into odr_guard_sh
Ralf W. Grosse-Kunstleve
committed
Fully document the ODR violations in the ODR guard itself and introduce PYBIND11_TYPE_CASTER_ODR_GUARD_ON_IF_AVAILABLE
Ralf W. Grosse-Kunstleve
committed
Update comment (incl. mention of deadsnakes known to not work as intended).
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 15, 2022

Use no-destructor idiom for type_caster_odr_guard_registry, as suggested by @laramiel
Ralf W. Grosse-Kunstleve
committed
Fix clang-tidy error: 'auto reg' can be declared as 'auto *reg' [readability-qualified-auto,-warnings-as-errors]
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 18, 2022

WIP
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 20, 2022

Revert "WIP" (tu_local_no_data_always_false_base experiment).
Ralf W. Grosse-Kunstleve
committed
Change PYBIND11_TYPE_CASTER_ODR_GUARD_ON to PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD, based on a suggestion by @rainwoodman
Ralf W. Grosse-Kunstleve
committed
Improved #if determining PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD, based on suggestion by @laramiel
Ralf W. Grosse-Kunstleve
committed
Make descr::sloc const, as suggested by @rainwoodman
Ralf W. Grosse-Kunstleve
committed
Rename macro to PYBIND11_DETAIL_TYPE_CASTER_ODR_GUARD_IMPL_DEBUG, as suggested by @laramiel
Ralf W. Grosse-Kunstleve
committed
Tweak comments some more (add "white hat hacker" analogy).
Ralf W. Grosse-Kunstleve
committed
Bring back PYBIND11_CPP17 in determining PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD, to hopefully resolve most if not all of the many CI failures (89 failing, 32 successful: https://github.com/pybin…
Ralf W. Grosse-Kunstleve
committed
Try another workaround for __has_builtin-related breakages (https://github.com/pybind/pybind11/runs/7430720321 ).
Ralf W. Grosse-Kunstleve
committed
Remove defined(__has_builtin) and subconditions.
Ralf W. Grosse-Kunstleve
committed
Update "known to not work" expectation in test and comment.
Ralf W. Grosse-Kunstleve
committed
pytest.skip num_violations == 0 only #ifdef __NO_INLINE__ (irrespective of the compiler)
Ralf W. Grosse-Kunstleve
committed

Commits on Jul 21, 2022

Systematically change all new #ifdef to #if defined (review suggestion).
Ralf W. Grosse-Kunstleve
committed
Bring back MSVC comment that got lost while experimenting.
Ralf W. Grosse-Kunstleve
committed