fix: support cross-compiles with classic Python #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
Skylion007
approved these changes
May 19, 2022
|
Looks like FindPython has the same check: https://github.com/Kitware/CMake/blob/07d351b535dde56a89aa6786a3f0701e3b159d44/Modules/FindPython/Support.cmake#L815-L817 so I'm pretty happy with it, though I'm having a different error later on for what I'm doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henry Schreiner [email protected]
Description
Drop the bit check for cross compiles (like for Pyodide). Also allow found values to be overridden if needed for future proofing cross compiles. See https://github.com/emscripten-forge/recipes/blob/main/recipes/recipes_emscripten/pybind11/patches/0001-no-bitsize-check.patch. I believe FindPython already supports cross-compiling.
Suggested changelog entry: