-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add err guard to capsule destructor and add a move to iostream #3958
chore: add err guard to capsule destructor and add a move to iostream #3958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get a chance to look closely today.
I don't fully understand how this plays with the pybind11_fail, but I feel sufficiently confident that this change will only make things better.
It would be good to note somewhere (here or PR description) how you came to add the error_guard (something failed? or did you just happen to notice?)
@rwgk I happened to notice that here: pybind11/include/pybind11/pytypes.h Line 1595 in a27914a
Thoughts @rwgk ? |
Description
Suggested changelog entry: