Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update NVIDIA-PGI CI workflow #3922

Merged
merged 3 commits into from
May 4, 2022
Merged

Chore: update NVIDIA-PGI CI workflow #3922

merged 3 commits into from
May 4, 2022

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented May 3, 2022 •
edited
Loading

Description

  • Update NVIDIA-PGI's compiler to the latest and greatest version

@Skylion007 Skylion007 requested a review from rwgk May 3, 2022 15:45
@Skylion007 Skylion007 changed the title Update PGI workflow Chore: update NVIDIA-PGI CI workflow May 3, 2022
@Skylion007 Skylion007 marked this pull request as ready for review May 3, 2022 15:46
@Skylion007 Skylion007 requested a review from henryiii as a code owner May 3, 2022 15:46
rwgk
rwgk approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Caveat: I don't know (at all) how important it is to keep testing with 20.9. But we can just add back 20.9 testing if someone critically depends on that particular version.

henryiii
henryiii approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only officially support the latest versions for secondary compilers.

@Skylion007
Copy link
Collaborator Author

The debian issue seems like a known issue with checkout and 32bit images? actions/checkout#334

@Skylion007 Skylion007 merged commit bdc7dd8 into pybind:master May 4, 2022
@Skylion007 Skylion007 deleted the skylion007/update-centos7-pgi-22.3 branch May 4, 2022 17:02
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 4, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 5, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @rwgk @henryiii