Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add perfect forwarding to make_iterator calls #3860

Merged
merged 1 commit into from
Apr 11, 2022
Merged

chore: Add perfect forwarding to make_iterator calls #3860

merged 1 commit into from
Apr 11, 2022

Conversation

Skylion007
Copy link
Collaborator

Description

  • I noticed that we weren't perfect forwarding the Extra args the entire call chain of make_iterator so I went ahead and added the missing std::forward calls so that the Extra args are properly forwarded.

Suggested changelog entry:

* Added missing perfect forwarding for ``make_iterator`` functions.

@Skylion007 Skylion007 merged commit e3aa215 into pybind:master Apr 11, 2022
@Skylion007 Skylion007 deleted the skylion007-perfect-forward-kv-iterator branch April 11, 2022 18:03
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 11, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 9, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@rwgk rwgk Awaiting requested review from rwgk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skylion007 @henryiii