-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better exception and error handling for capsules #3825
fix: better exception and error handling for capsules #3825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this cleanup, the revised code makes a lot more sense!
I'll try to run this through our global testing tonight, but if you need this before I have the results, please go ahead.
standing? standard? Maybe: ? |
The test ID for the global testing is |
The global testing finished without finding any issues. |
@rwgk Fixed spelling errors in the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic to me. :)
* Make capsule errors better match python
Description
Suggested changelog entry: