Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MSVC 2022 C++20 GitHub Action #3732

Merged
merged 3 commits into from
Feb 14, 2022
Merged

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 14, 2022

Description

test_eigen is currently disabled (similar to the existing MSVC 2019 C++20 GHA), awaiting Eigen compatibility fixes.

See also:

Suggested changelog entry:

MSVC 2022 C++20 coverage was added to GitHub Actions (test_eigen is currently disabled).

@rwgk rwgk marked this pull request as ready for review February 14, 2022 13:44
@rwgk rwgk requested a review from henryiii as a code owner February 14, 2022 13:44
@rwgk rwgk requested a review from Skylion007 February 14, 2022 13:44
@rwgk rwgk mentioned this pull request Feb 14, 2022
@henryiii
Copy link
Collaborator

Can't we just add this to the 2019 jobs?

@rwgk
Copy link
Collaborator Author

rwgk commented Feb 14, 2022

Can't we just add this to the 2019 jobs?

Thanks a lot for jumping in!

One difference I noticed is that the 2019 job doesn't include --target cpptest and --target test_cmake_build, therefore I decided to start by adding a completely new block.

@henryiii
Copy link
Collaborator

Okay, reverted. We can clean up eventually. I also notice this is 32-bit only, which is odd.

I'm sad to see we actually had MSVC 2015 working on windows-2019, that does prove it's available there (which I had noticed in Scikit-build), but we can't run 2017 on GHA at all post windows-2016.

@rwgk
Copy link
Collaborator Author

rwgk commented Feb 14, 2022

Thanks Henry! Merging, then retesting #3722.

@rwgk rwgk merged commit 4415647 into pybind:master Feb 14, 2022
@rwgk rwgk deleted the adding_msvc2022_c++20 branch February 14, 2022 17:29
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 14, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants