Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop Python 3.5 #3719

Merged
merged 8 commits into from
Feb 12, 2022
Merged

chore: drop Python 3.5 #3719

merged 8 commits into from
Feb 12, 2022

Conversation

henryiii
Copy link
Collaborator

Dropping Python 3.5 support.

  • chore: drop Python 3.5 support
  • chore: more fstrings with flynt's help
  • ci: drop Python 3.5
  • chore: bump dependency versions

Description

Suggested changelog entry:

* Removed Python 3.5 support.

@henryiii henryiii force-pushed the henryiii/drop/35 branch 2 times, most recently from 5cd529b to 4fe5711 Compare February 11, 2022 05:50
@henryiii henryiii marked this pull request as ready for review February 11, 2022 05:51
This was referenced Feb 11, 2022
Merged
Draft
@henryiii
Copy link
Collaborator Author

henryiii commented Feb 11, 2022 •
edited
Loading

I can fix the deprecation warning I think, and PyPy 3.8 NumPy might be buggy still. I’ll drop PyPy 3.6, it is unsupported.

@henryiii
Copy link
Collaborator Author

Note that you currently cannot combine this with a py::args argument.

I think this was fixed…

@henryiii
Copy link
Collaborator Author

Forgot we have a pytest.ini for some situations. Will have to check.

Skylion007
Skylion007 reviewed Feb 11, 2022
View reviewed changes
setup.py Show resolved Hide resolved
@henryiii
Copy link
Collaborator Author

henryiii commented Feb 11, 2022 •
edited
Loading

I'd rather disallow non-f-strings via pylint, vs. have flynt always running to try to convert them. It's actually only a hair stronger at converting them than pyupgrade unless you pass --aggressive, anyway.

@henryiii henryiii force-pushed the henryiii/drop/35 branch 2 times, most recently from 0f71f9f to 20046be Compare February 11, 2022 16:15
@henryiii
Copy link
Collaborator Author

I left off the Flynt addition, but kept the smart quotes one + fix.

@henryiii henryiii force-pushed the henryiii/drop/35 branch 2 times, most recently from d7af4b6 to bc9bf7f Compare February 11, 2022 16:36
@henryiii
Copy link
Collaborator Author

Any thoughts to the failing valgrind run? Will not be able to work on this more for now.

@henryiii
Copy link
Collaborator Author

henryiii commented Feb 11, 2022 •
edited
Loading

We have 3 new errors in valgrind when going from numpy 1.21 to numpy 1.22, so I left this at numpy 1.21 for Python < 3.10. Ready for review.

@henryiii henryiii merged commit 522c59c into master Feb 12, 2022
@henryiii henryiii deleted the henryiii/drop/35 branch February 12, 2022 00:06
This was referenced Feb 14, 2022
Merged
Closed
Merged
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryiii @rwgk @Skylion007