Replace usage of deprecated Eigen class MappedSparseMatrix. #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eigen::MappedSparseMatrix has been deprecated since Eigen 3.3 from 2016. Use the equivalent modern syntax Eigen::Map<Eigen::SparseMatrix<...>>.
Replace usage of deprecated Eigen class
|
Currently, the minimum supported Eigen version in PyBind11 is 3.2.7. Did this API exist in 3.2? Otherwise, we need to either raise the minimum Eigen version or add an ifdef backport. |
|
@Skylion007 I don't think this existed in Eigen 3.2. What would you prefer, raising the minimum version or an ifdef? Eigen 3.2 is pretty ancient. |
|
@Skylion007 what do you prefer? |
|
If it's not too much trouble to enable a backport with a "using"/typedef, it would be nice to keep support for Eigen 3.2. |
|
@Skylion007 PTAL |
henryiii
approved these changes
Nov 22, 2021
henryiii
reviewed
Nov 22, 2021
Skylion007
approved these changes
Nov 22, 2021
|
@rwgk Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace usage of deprecated Eigen class MappedSparseMatrix.
Description
Eigen::MappedSparseMatrixhas been deprecated since Eigen 3.3 from 2016. Use the equivalent modern syntaxEigen::Map<Eigen::SparseMatrix<...>>.The deprecated class was removed on the Eigen master branch in:
https://gitlab.com/libeigen/eigen/-/commit/7e586635ba85ba926ba3148f8d14beca3535f970
Suggested changelog entry: