Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): support conan's multiple includes of all files #3420

Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix(build): support conan's multiple includes of all files #3420

merged 1 commit into from
Oct 27, 2021

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Oct 27, 2021 •
edited
Loading

Description

Conan wasn't supported, now it is. Closes #3388.

Suggested changelog entry:

* Support multiple raw inclusion of CMake helper files (Conan.io does this for multi-config generators).

@henryiii
Copy link
Collaborator Author

unable to access 'https://github.com/pybind/pybind11/': The requested URL returned error: 429

You'd think GitHub Actions wouldn't have trouble accessing GitHub...

@henryiii henryiii merged commit 90707b4 into pybind:master Oct 27, 2021
@henryiii henryiii deleted the henryiii/fix/cmakeconan branch October 27, 2021 19:06
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Oct 27, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Dec 21, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: pybind11::python_headers added multiple times when using multi-config cmake generators
2 participants
@henryiii @Skylion007