[smart_holder] Introducing PYBIND11_INTERNALS_SH_DEF. #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ybind#2939. For compatibility with PR pybind#3275.
rwgk
changed the title
|
Hi @charlesbeattie, could you please help reviewing this small change (smart_holder branch)? (The CI-SH-DEF pypy3 macos-latest failure is a flake: occasional download issue.) |
|
Looks good to me. |
|
Thanks @charlesbeattie! I clicked through all 5 CI failures, they are all intermittent macos brew boost download issues. I'll ignore those, especially because this change was already tested PR #3282. |
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Feb 14, 2024
pybind#3283 (merged 2021-09-20).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hindsight, this is clearly the better approach.