Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set __file__ constant when using eval_file (#1300) #3233

Merged
merged 13 commits into from
Sep 9, 2021
11 changes: 11 additions & 0 deletions include/pybind11/eval.h
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,17 @@ object eval_file(str fname, object global = globals(), object local = object())
pybind11_fail("File \"" + fname_str + "\" could not be opened!");
}

if (!global.contains("__file__")) {
#if PY_VERSION_HEX >= 0x03000000
global["__file__"] = std::move(fname);
#else
// In Python2, this should be encoded by getfilesystemencoding.
// We are just assuming it's UTF-8 since Python2 is past EOL anyway.
// See PR#3233
global["__file__"] = bytes(fname);
#endif
}

#if PY_VERSION_HEX < 0x03000000 && defined(PYPY_VERSION)
PyObject *result = PyRun_File(f, fname_str.c_str(), start, global.ptr(),
local.ptr());
Expand Down
3 changes: 3 additions & 0 deletions tests/test_cmake_build/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,8 @@

import test_cmake_build

if str is not bytes: # If not Python2
assert isinstance(__file__, str) # Test this is properly set

assert test_cmake_build.add(1, 2) == 3
print("{} imports, runs, and adds: 1 + 2 = 3".format(sys.argv[1]))