Always check __STDC_LIB_EXT1__ before __STDC_WANT_LIB_EXT1__ #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… __STDC_LIB_EXT1__ is not defined by the implementation. Follow-on to PR pybind#3129.
henryiii
approved these changes
Jul 28, 2021
|
Thanks Henry! |
henryiii
pushed a commit
to henryiii/pybind11
that referenced
this pull request
Jul 29, 2021
… __STDC_LIB_EXT1__ is not defined by the implementation. (pybind#3151) Follow-on to PR pybind#3129.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accommodating environments that define
__STDC_WANT_LIB_EXT1__even if__STDC_LIB_EXT1__is not defined by the implementation.Follow-on to PR #3129.
Fixes Google-internal macos builds, but this is generally more correct.
Changelog not needed: PR #3129 was not released yet.