feat(package): support pipx run #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
approved these changes
Jul 15, 2021
|
Looks reasonable once we figure out the PIP CI failures. |
Skylion007
reviewed
Jul 15, 2021
tools/setup_main.py.in
Outdated
| @@ -33,6 +33,9 @@ setup( | |||
| "console_scripts": [ | |||
| "pybind11-config = pybind11.__main__:main", | |||
| ] | |||
There was a problem hiding this comment.
Thanks, sorry, forgot to push the correction till just now.
There was a problem hiding this comment.
I normally would put this in setup.cfg, but it's only valid for the non-global package, not both. :)
henryiii
force-pushed
the
henryiii/feat/pipx
branch
from
c4eb74e to
f73d455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very minor feature - support for pipx run! So
$(pipx run pybind11 --includes)can even be used to build an example by hand without installing anything! :)
Suggested changelog entry:
* Support pipx run, such as `pipx run pybind11 --include` for a quick compile.