Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reduce visibility of 3.9.0 warning #3105

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jul 13, 2021

3.9.0 shouldn't be that common, and most users should be using 2.6 or better (at least if they are reading the latest docs).

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

built with Python 3.9.0 will correctly avoid the leak when run in Python 3.9.1.
This issue was `fixed in Python <https://github.com/python/cpython/pull/22670>`_.
As a mitigation for this bug, pybind11 2.6.0 or newer includes a (possibly
temporary) workaround specifically when Python 3.9.0 is detected at runtime,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete (possibly temporary)
?
workarounds usually don't get deleted for a long time

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, changed.

@henryiii henryiii force-pushed the henryiii/docs/39warn branch from f95d201 to a2cf7dd Compare July 15, 2021 14:33
@henryiii henryiii merged commit 31843d4 into pybind:master Jul 15, 2021
@henryiii henryiii deleted the henryiii/docs/39warn branch July 15, 2021 19:01
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 15, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants