Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelog #3099

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Conversation

henryiii
Copy link
Collaborator

Description

Updates the changelog with the marked PRs.

@rwgk
Copy link
Collaborator

rwgk commented Jul 12, 2021

The flake is #2995 again.
I think it's very important to merge #2995 before the 2.7 release.

@henryiii
Copy link
Collaborator Author

But on PyPy macOS this time?

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, my main concern is that #2995 isn't included.

I think we need to be completely open about the undefined behavior, to not mislead users. I'm also thinking that we are more likely to attract a volunteer to develop a fix if we're open about the issue.

To add my own experience, it is no exaggeration that I scrolled through failed jobs 100+ times to be sure it's that flake, and it's an error each time I run TSAN.

I'd be happy quickly address suggestions on #2995.

docs/changelog.rst Outdated Show resolved Hide resolved
@henryiii
Copy link
Collaborator Author

This is not the final changelog before 2.7 (though I expect we are getting close), just an update to the current changelog that has been long delayed.

@henryiii henryiii force-pushed the henryiii/docs/changelog branch from 510c76d to a808c17 Compare July 12, 2021 20:59
@henryiii henryiii merged commit 6a644c8 into pybind:master Jul 13, 2021
@henryiii henryiii deleted the henryiii/docs/changelog branch July 13, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants