Fixing select clang-tidy issues to reduce NOLINTNEXTLINE use. #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter and clang-format issues. This was really meant to be part of PR pybind#3051 but was held back either out of an abundance of caution, or because of confusion caused by stray semicolons.
Skylion007
approved these changes
Jul 9, 2021
|
Thanks @Skylion007 for the review, and for your help while I was working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was really meant to be part of PR #3051 but was held back either out of an abundance of caution, or because of confusion caused by stray semicolons.
The particular
NOLINTs removed here were stumbling stones for the ongoing work under PR #3078. Breaking out the fixes into a separate PR to disconnect them from other questions.clang-format-diff was applied.