Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions: Add doc on incorrect argument index #2979

Merged
merged 1 commit into from
May 6, 2021

Conversation

EricCousineau-TRI
Copy link
Collaborator

test_call_policies: Explicitly check free-functions and static methods

Description

Very minor follow-up; ended up doing this b/c I couldn't read in #2978 😅

Suggested changelog entry:

N/A.

Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sure, whatevs

(This was the requested review comment ;) )

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

test_call_policies: Explicitly check free-functions and static methods
@EricCousineau-TRI
Copy link
Collaborator Author

I'ma chalk the Mac failure to a flake; merging!!!

@EricCousineau-TRI EricCousineau-TRI merged commit b6ec0e9 into pybind:master May 6, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 6, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants