Allow function pointer extraction from overloaded functions #2944

otamachan · 2021-04-10T06:55:58Z

Description

When I try to avoid C++ -> Python -> C++ roundtrip for overloaded functions, it only works for the first overloaded function.
This PR allows function pointer extraction from all overloaded functions.

I added a failure test case. Without the fix in this PR, it fails as follows:

>       assert (
            m.test_dummy_function(m.dummy_function_overloaded)
            == "matches dummy_function: eval(1) = 2"
        )
E       assert "can't conver...: eval(1) = 2" == 'matches dumm...: eval(1) = 2'
E         - matches dummy_function: eval(1) = 2
E         + can't convert to function pointer: eval(1) = 2

I applied clang-format to only the related code block so the style was changed a bit.

Suggested changelog entry:

Allow function pointer extraction from overloaded functions

henryiii · 2021-04-10T15:05:22Z

include/pybind11/functional.h

+                    value = ((capture *) &rec->data)->f;
+                    return true;
+                }
+                rec = rec->next;


This line (and the while) is the only actual change, I think. The rest is formatting. Note that if we used clang-format, this would not randomly change. :)

Yep, I feel the same.

rwgk

Looks great to me, thanks for the fix Tamaki!
(I'm a bit amazed that this oversight survived for so long.)

I already ran this PR through our Google-internal global testing system: all green.
I'll go ahead with merging this PR.

rwgk · 2021-04-13T23:50:27Z

include/pybind11/functional.h

+                    value = ((capture *) &rec->data)->f;
+                    return true;
+                }
+                rec = rec->next;


Yep, I feel the same.

v2.7.0 (Jul 16, 2021) --------------------- New features: * Enable ``py::implicitly_convertible<py::none, ...>`` for ``py::class_``-wrapped types. `#3059 <https://github.com/pybind/pybind11/pull/3059>`_ * Allow function pointer extraction from overloaded functions. `#2944 <https://github.com/pybind/pybind11/pull/2944>`_ * NumPy: added ``.char_()`` to type which gives the NumPy public ``char`` result, which also distinguishes types by bit length (unlike ``.kind()``). `#2864 <https://github.com/pybind/pybind11/pull/2864>`_ * Add ``pybind11::bytearray`` to manipulate ``bytearray`` similar to ``bytes``. `#2799 <https://github.com/pybind/pybind11/pull/2799>`_ * ``pybind11/stl/filesystem.h`` registers a type caster that, on C++17/Python 3.6+, converts ``std::filesystem::path`` to ``pathlib.Path`` and any ``os.PathLike`` to ``std::filesystem::path``. `#2730 <https://github.com/pybind/pybind11/pull/2730>`_ * A ``PYBIND11_VERSION_HEX`` define was added, similar to ``PY_VERSION_HEX``. `#3120 <https://github.com/pybind/pybind11/pull/3120>`_ Signed-off-by: Zheng Ruoqin <[email protected]> Signed-off-by: Khem Raj <[email protected]>

v2.7.0 (Jul 16, 2021) --------------------- New features: * Enable ``py::implicitly_convertible<py::none, ...>`` for ``py::class_``-wrapped types. `#3059 <https://github.com/pybind/pybind11/pull/3059>`_ * Allow function pointer extraction from overloaded functions. `#2944 <https://github.com/pybind/pybind11/pull/2944>`_ * NumPy: added ``.char_()`` to type which gives the NumPy public ``char`` result, which also distinguishes types by bit length (unlike ``.kind()``). `#2864 <https://github.com/pybind/pybind11/pull/2864>`_ * Add ``pybind11::bytearray`` to manipulate ``bytearray`` similar to ``bytes``. `#2799 <https://github.com/pybind/pybind11/pull/2799>`_ * ``pybind11/stl/filesystem.h`` registers a type caster that, on C++17/Python 3.6+, converts ``std::filesystem::path`` to ``pathlib.Path`` and any ``os.PathLike`` to ``std::filesystem::path``. `#2730 <https://github.com/pybind/pybind11/pull/2730>`_ * A ``PYBIND11_VERSION_HEX`` define was added, similar to ``PY_VERSION_HEX``. `#3120 <https://github.com/pybind/pybind11/pull/3120>`_ Signed-off-by: Zheng Ruoqin <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>

otamachan added 2 commits April 10, 2021 15:44

Add a failure test for overloaded functions

10a1c96

Allow function pointer extraction from overloaded functions

3662b9c

henryiii reviewed Apr 10, 2021

View reviewed changes

henryiii approved these changes Apr 10, 2021

View reviewed changes

rwgk approved these changes Apr 13, 2021

View reviewed changes

include/pybind11/functional.h

value = ((capture *) &rec->data)->f;

return true;

}

rec = rec->next;

Copy link

Collaborator

rwgk Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I feel the same.

rwgk merged commit 6709abb into pybind:master Apr 13, 2021

github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 13, 2021

henryiii removed the needs changelog Possibly needs a changelog entry label Jul 13, 2021

rwgk mentioned this pull request Feb 10, 2023

FWD pybind11 google/pybind11clif#2944

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow function pointer extraction from overloaded functions #2944

Allow function pointer extraction from overloaded functions #2944

otamachan commented Apr 10, 2021

henryiii Apr 10, 2021 •

edited

Loading

rwgk Apr 13, 2021

rwgk left a comment

rwgk Apr 13, 2021

Allow function pointer extraction from overloaded functions #2944

Allow function pointer extraction from overloaded functions #2944

Conversation

otamachan commented Apr 10, 2021

Description

Suggested changelog entry:

henryiii Apr 10, 2021 • edited Loading

Choose a reason for hiding this comment

rwgk Apr 13, 2021

Choose a reason for hiding this comment

rwgk left a comment

Choose a reason for hiding this comment

rwgk Apr 13, 2021

Choose a reason for hiding this comment

henryiii Apr 10, 2021 •

edited

Loading