Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizing suppression for pypocketfft. #2896

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Mar 9, 2021

This valgrind error started appearing today, for completely unrelated changes. E.g.:

https://github.com/pybind/pybind11/pull/2895/checks?check_run_id=2061696834

==9513== 104 bytes in 1 blocks are definitely lost in loss record 6,250 of 8,539
==9513==    at 0x4A3852A: operator new(unsigned long) (vg_replace_malloc.c:342)
==9513==    by 0x153EFF33: PyInit_pypocketfft (in /home/runner/venv-3.9/lib/python3.9/site-packages/scipy/fft/_pocketfft/pypocketfft.cpython-39-x86_64-linux-gnu.so)
==9513==    by 0x4F5016: _PyImport_LoadDynamicModuleWithSpec (importdl.c:164)
==9513==    by 0x4F454A: _imp_create_dynamic_impl.constprop.0 (import.c:2297)
==9513==    by 0x4F44AD: _imp_create_dynamic (import.c.h:330)
==9513==    by 0x62546B: cfunction_vectorcall_FASTCALL (methodobject.c:426)
==9513==    by 0x4318A2: PyVectorcall_Call (call.c:231)
==9513==    by 0x431596: _PyObject_Call (call.c:266)
==9513==    by 0x4314E3: PyObject_Call (call.c:293)
==9513==    by 0x4D49C1: do_call_core (ceval.c:5092)
==9513==    by 0x4D32F7: _PyEval_EvalFrameDefault (ceval.c:3580)
==9513==    by 0x4C9161: _PyEval_EvalFrame (pycore_ceval.h:40)
==9513==    by 0x4C9161: _PyEval_EvalCode (ceval.c:4327)
==9513== 

@YannickJadoul
Copy link
Collaborator

For the record, we were already suppressing the same leak but with _imp_create_dynamic_impl.constprop.3 in the stack instead of _imp_create_dynamic_impl.constprop.0. This just generalizes that existing suppression rule to not care about that number. Hopefully that's better/enough to avoid future issues.

@YannickJadoul YannickJadoul changed the title Adding suppression for pypocketfft. Generalizing suppression for pypocketfft. Mar 9, 2021
@rwgk
Copy link
Collaborator Author

rwgk commented Mar 9, 2021

Thanks a lot Yannick!

@rwgk rwgk merged commit 0e01c24 into pybind:master Mar 9, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 9, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Mar 9, 2021
@rwgk rwgk deleted the valgrind_pypocketfft branch March 9, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants