2.6.0: Use sorted(glob()) in example setup.py #2561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest changing the example setup.py as follows below, to use a sorted glob instead of naming one source file.
This strategy eliminates errors from forgetting to enumerate source files one by one when a new .cpp is added. Using
sorted(glob())
also ensures the build will be reproducible on file systems that do not enumerate files in sorted order (most Linux filesystems).I also added a missing code-block directive.