Bool conversion: only special-case np.bool_ in 1st pass

pybind · Jul 23, 2017 · 31401f8 · 31401f8
1 parent 9b4f569
commit 31401f8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/include/pybind11/cast.h b/include/pybind11/cast.h
@@ -1078,8 +1078,11 @@ template <> class type_caster<bool> {
             }
             return false;
         }
-        if (hasattr(src, "dtype")) {
+        else if (hasattr(src, "dtype")) {
             // Allow non-implicit conversion for numpy booleans
+            //
+            // Note: this will only run in the first (noconvert) pass;
+            // during the second pass, it will be handled by __bool__ logic.
             auto dtype = src.attr("dtype");
             if (hasattr(dtype, "kind") && dtype.attr("kind").cast<char>() == 'b') {
                 value = PyObject_IsTrue(src.ptr()) == 1;