Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainers and trainees #207

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Conversation

brosaplanella
Copy link
Member

List accurate as of Oct 2024

@brosaplanella brosaplanella requested review from arjxn-py, valentinsulzer and agriyakhetarpal and removed request for arjxn-py October 11, 2024 15:22
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for pybamm-developer-preview ready!

Name Link
🔨 Latest commit cbe86fe
🔍 Latest deploy log https://app.netlify.com/sites/pybamm-developer-preview/deploys/67094c0626209800088f2fc1
😎 Deploy Preview https://deploy-preview-207--pybamm-developer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

arjxn-py

This comment was marked as outdated.

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd want to also add Marc to the maintainers, I assume that you're on it.

@arjxn-py arjxn-py dismissed their stale review October 11, 2024 15:43

Outdated

@brosaplanella
Copy link
Member Author

I think I have (it is in the MAINTAINERS file) but it does not appear in the generated page. Don't know why...

@arjxn-py
Copy link
Member

I think I have (it is in the MAINTAINERS file) but it does not appear in the generated page. Don't know why...

Yes, I don't see Marc in the all contributors list, seems like we never added him in the first place. Happy to request all contributor bot to add Marc and then Manually generate teams again.

@arjxn-py
Copy link
Member

Here - pybamm-team/PyBaMM#4505, feel free to press the button.

@brosaplanella
Copy link
Member Author

It said it still needed a review. Can you approve again, @arjxn-py? Feel free to merge afterwards, I need to go now.

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brosaplanella, looks great :)

@arjxn-py arjxn-py merged commit e4b96e6 into main Oct 11, 2024
5 of 6 checks passed
@arjxn-py arjxn-py deleted the update-maintainers-and-trainees branch October 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants