-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maintainers and trainees #207
Conversation
✅ Deploy Preview for pybamm-developer-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…eam/pybamm.org into update-maintainers-and-trainees
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd want to also add Marc to the maintainers, I assume that you're on it.
I think I have (it is in the MAINTAINERS file) but it does not appear in the generated page. Don't know why... |
Yes, I don't see Marc in the all contributors list, seems like we never added him in the first place. Happy to request all contributor bot to add Marc and then Manually generate teams again. |
Here - pybamm-team/PyBaMM#4505, feel free to press the button. |
It said it still needed a review. Can you approve again, @arjxn-py? Feel free to merge afterwards, I need to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brosaplanella, looks great :)
List accurate as of Oct 2024