Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 912 tab cooling #965

Merged
merged 17 commits into from
Apr 29, 2020
Merged

Issue 912 tab cooling #965

merged 17 commits into from
Apr 29, 2020

Conversation

Scottmar93
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Scottmar93 Scottmar93 requested a review from rtimms April 20, 2020 11:35
Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks Scott! Just a couple of comments. I guess the tab location thing might be a bit messy to address

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #965 into develop will increase coverage by 0.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #965      +/-   ##
===========================================
+ Coverage    97.34%   98.12%   +0.78%     
===========================================
  Files          222      221       -1     
  Lines        11622    11569      -53     
===========================================
+ Hits         11313    11352      +39     
+ Misses         309      217      -92     
Impacted Files Coverage Δ
pybamm/models/submodels/thermal/x_full.py 100.00% <ø> (ø)
pybamm/models/submodels/thermal/lumped.py 100.00% <100.00%> (ø)
...mal/pouch_cell/pouch_cell_1D_current_collectors.py 100.00% <100.00%> (ø)
...mal/pouch_cell/pouch_cell_2D_current_collectors.py 100.00% <100.00%> (ø)
pybamm/parameters/standard_parameters_lead_acid.py 99.32% <100.00%> (+<0.01%) ⬆️
...bamm/parameters/standard_parameters_lithium_ion.py 100.00% <100.00%> (ø)
pybamm/parameters/thermal_parameters.py 100.00% <100.00%> (ø)
pybamm/solvers/scikits_ode_solver.py 87.32% <0.00%> (-0.84%) ⬇️
pybamm/solvers/base_solver.py 99.50% <0.00%> (-0.23%) ⬇️
pybamm/solvers/scikits_dae_solver.py 98.27% <0.00%> (-0.09%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde479d...ffffe74. Read the comment docs.

@Scottmar93 Scottmar93 merged commit 6b62171 into develop Apr 29, 2020
@valentinsulzer valentinsulzer deleted the issue-912-tab-cooling branch May 27, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants