-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 912 tab cooling #965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great thanks Scott! Just a couple of comments. I guess the tab location thing might be a bit messy to address
pybamm/input/parameters/lead-acid/experiments/1C_discharge_from_full/parameters.csv
Show resolved
Hide resolved
pybamm/models/submodels/thermal/pouch_cell/pouch_cell_1D_current_collectors.py
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #965 +/- ##
===========================================
+ Coverage 97.34% 98.12% +0.78%
===========================================
Files 222 221 -1
Lines 11622 11569 -53
===========================================
+ Hits 11313 11352 +39
+ Misses 309 217 -92
Continue to review full report at Codecov.
|
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: