Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#941 filter out discon events after the end of the solver time #945

Merged
merged 3 commits into from
Apr 7, 2020

Conversation

martinjrobins
Copy link
Contributor

Description

Fixes #941

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • [] All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #945 into develop will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #945      +/-   ##
===========================================
+ Coverage    98.05%   98.26%   +0.20%     
===========================================
  Files          226      242      +16     
  Lines        11164    12310    +1146     
===========================================
+ Hits         10947    12096    +1149     
+ Misses         217      214       -3     
Impacted Files Coverage Δ
pybamm/solvers/base_solver.py 99.72% <100.00%> (+<0.01%) ⬆️
...dels/full_battery_models/lead_acid/higher_order.py 98.47% <0.00%> (-0.52%) ⬇️
pybamm/models/submodels/porosity/base_porosity.py 100.00% <0.00%> (ø)
...ybamm/models/full_battery_models/lead_acid/full.py 100.00% <0.00%> (ø)
...ybamm/models/full_battery_models/lead_acid/loqs.py 100.00% <0.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/dfn.py 100.00% <0.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/spm.py 100.00% <0.00%> (ø)
...amm/models/full_battery_models/lithium_ion/spme.py 100.00% <0.00%> (ø)
...amm/models/submodels/porosity/constant_porosity.py 100.00% <0.00%> (ø)
...amm/models/submodels/thermal/x_full/base_x_full.py 100.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3934ad4...23d6911. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinjrobins martinjrobins merged commit 96e7811 into develop Apr 7, 2020
@valentinsulzer valentinsulzer deleted the issue-941-discon-end-time branch April 8, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discontinuities get detected beyond the specified time interval =>IndexError
2 participants