Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#917 fix function that returns float #919

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Fixes #917

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer valentinsulzer requested a review from rtimms March 26, 2020 00:18
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #919 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #919      +/-   ##
==========================================
+ Coverage       98%     98%   +<.01%     
==========================================
  Files          207     207              
  Lines        10912   10914       +2     
==========================================
+ Hits         10694   10696       +2     
  Misses         218     218
Impacted Files Coverage Δ
pybamm/parameters/parameter_values.py 99.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca1f30...799e09b. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #919 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #919   +/-   ##
========================================
  Coverage    98.00%   98.00%           
========================================
  Files          207      207           
  Lines        10912    10914    +2     
========================================
+ Hits         10694    10696    +2     
  Misses         218      218           
Impacted Files Coverage Δ
pybamm/parameters/parameter_values.py 99.21% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca1f30...799e09b. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@valentinsulzer valentinsulzer merged commit 998b2c6 into develop Mar 26, 2020
@valentinsulzer valentinsulzer deleted the issue-917-parameter branch March 26, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of constant parameter functions throws an error
2 participants