Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#901 corrected notebook #903

Merged
merged 2 commits into from
Mar 22, 2020
Merged

#901 corrected notebook #903

merged 2 commits into from
Mar 22, 2020

Conversation

Scottmar93
Copy link
Contributor

Description

changed typical current -> current function

added a repr function to parameter values use pformat to print nicely in notebook.

Fixes #901

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • [] No style issues: $ flake8
  • [] All tests pass: $ python run-tests.py --unit
  • [] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Scottmar93 Scottmar93 requested review from valentinsulzer and rtimms and removed request for valentinsulzer March 20, 2020 16:27
Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #903 into develop will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #903      +/-   ##
===========================================
- Coverage    97.82%   97.81%   -0.01%     
===========================================
  Files          207      207              
  Lines        10737    10740       +3     
===========================================
+ Hits         10503    10505       +2     
- Misses         234      235       +1
Impacted Files Coverage Δ
pybamm/parameters/parameter_values.py 99.21% <66.66%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43060b...d7c4c9f. Read the comment docs.

@Scottmar93 Scottmar93 merged commit 1b0e0c5 into develop Mar 22, 2020
@Scottmar93 Scottmar93 deleted the issue-901-fix-notebook-2 branch March 22, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix notebook 2
2 participants