Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 869 search #875

Merged
merged 6 commits into from
Mar 10, 2020
Merged

Issue 869 search #875

merged 6 commits into from
Mar 10, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Mar 9, 2020

Description

Adds a search functionailty to pybamm.FuzzyDict so that users can search ParameterValues and model.variables

Fixes #869

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #875 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #875      +/-   ##
===========================================
+ Coverage    97.75%   97.75%   +<.01%     
===========================================
  Files          202      202              
  Lines        10459    10475      +16     
===========================================
+ Hits         10224    10240      +16     
  Misses         235      235
Impacted Files Coverage Δ
pybamm/parameters/parameter_values.py 100% <100%> (ø) ⬆️
pybamm/util.py 97.7% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8edbd53...6a2dc1c. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@rtimms rtimms merged commit 150f07f into develop Mar 10, 2020
@rtimms rtimms deleted the issue-869-search branch March 10, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search parameters and variables
2 participants