-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 790 param not recognized #796
Conversation
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
==========================================
- Coverage 98.49% 98.47% -0.02%
==========================================
Files 179 181 +2
Lines 10133 10156 +23
==========================================
+ Hits 9980 10001 +21
- Misses 153 155 +2
Continue to review full report at Codecov.
|
Hey @tinosulzer what is the process for adding new parameters now? |
Same process as before, but if you try to update a parameter that didn't exist before there will be an error that can be overwritten by setting an extra flag in |
Description
Add fuzzy dict and raise errors if a parameter is updated that wasn't previously defined (so users don't think they've updated them when they haven't)
Fixes #790
Fixes #662
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: