Issue 492 potentiostatic #751

valentinsulzer · 2019-11-30T00:15:47Z

Description

Add models for voltage-controlled and power-controlled discharge

Fixes #492

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

New feature (non-breaking change which adds functionality)
Optimization (back-end change that speeds up the code)
Bug fix (non-breaking change which fixes an issue)

Key checklist:

No style issues: $ flake8
All tests pass: $ python run-tests.py --unit
The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

Code is commented, particularly in hard-to-understand areas
Tests added that prove fix is effective or that feature works

codecov · 2019-12-04T01:36:28Z

Codecov Report

Merging #751 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   98.39%   98.35%   -0.04%     
==========================================
  Files         176      179       +3     
  Lines        9701     9810     +109     
==========================================
+ Hits         9545     9649     +104     
- Misses        156      161       +5

Impacted Files	Coverage Δ
...amm/models/submodels/current_collector/__init__.py	`100% <ø> (ø)`	⬆️
...ollector/effective_resistance_current_collector.py	`96.29% <ø> (ø)`	⬆️
...ttery_models/lithium_ion/base_lithium_ion_model.py	`100% <ø> (ø)`	⬆️
...models/current_collector/base_current_collector.py	`100% <ø> (ø)`	⬆️
pybamm/parameters/electrical_parameters.py	`100% <ø> (ø)`	⬆️
...m/models/full_battery_models/base_battery_model.py	`100% <100%> (+0.34%)`	⬆️
pybamm/models/submodels/electrode/ohm/full_ohm.py	`100% <100%> (ø)`	⬆️
...l_battery_models/lead_acid/base_lead_acid_model.py	`100% <100%> (ø)`	⬆️
pybamm/models/submodels/base_submodel.py	`100% <100%> (ø)`	⬆️
pybamm/spatial_methods/zero_dimensional_method.py	`100% <100%> (ø)`	⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75de8c...b54eb0e. Read the comment docs.

rtimms

this looks great, thanks @tinosulzer !

rtimms · 2019-12-13T11:15:24Z

input/parameters/lead-acid/experiments/1C_discharge_from_full/parameters.csv

@@ -10,8 +10,7 @@ Number of electrodes connected in parallel to make a cell,8,Manufacturer,
 Number of cells connected in series to make a battery,6,Manufacturer,
 Lower voltage cut-off [V],1.73,,(just under) 10.5V across 6-cell battery
 Upper voltage cut-off [V],2.44,,(just over) 14.5V across 6-cell battery
-C-rate,1,,
-Current function,[constant],,
+C-rate,0.1,,


should this still be 1?

one of the tests failed when it was 1C so I just lazily changed it so 0.1C, don't really care about lead-acid any more ...

rtimms · 2019-12-13T11:16:27Z

input/parameters/lithium-ion/cells/kokam_Marquis2019/parameters.csv

@@ -34,3 +34,4 @@ Positive current collector thermal conductivity [W.m-1.K-1],237,,
 ,,,
 # Electrical,,,
 Cell capacity [A.h],0.680616,,24 Ah/m2 * 0.137m * 0.207m
+Typical current [A],1.46925726107,,1C current


should this just be equal to the cell capacity?

rtimms · 2019-12-13T11:26:29Z

pybamm/models/submodels/external_circuit/function_control_external_circuit.py

+from .base_external_circuit import BaseModel, LeadingOrderBaseModel
+
+
+class FunctionControl(BaseModel):


this is great!

rtimms · 2019-12-13T11:27:32Z

pybamm/parameters/parameter_values.py

        # reset processed symbols
        self._processed_symbols = {}

    def check_and_update_parameter_values(self, values):
-        # Make sure "C-rate" and current are both non-zero
-        if "C-rate" in values and values["C-rate"] == 0:
+        # Make typical current is non-zero


make sure typical...

valentinsulzer and others added 28 commits November 14, 2019 08:40

#492 reformat constant current to be a submodel

c16b916

#492 merge master

8ff9640

#492 fix bugs

ab9d5a6

#492 constant voltage works for DFN

ee030ee

#492 get potentiostatic working for 1D lithium-ion

049960d

#492 get working for 3d (in theory)

7ee11c5

#492 reorganise and add power

c2b7e38

#492 add charging strategies example

8561598

#492 add docs and unit tests

e968272

#492 merge master

d63f838

#492 add integration test - wrong current

db3ebbb

#492 trying to get charging strategies working

a24543c

#492 more reformatting, need to figure out currents still

e14811d

Merge branch 'master' into issue-492-potentiostatic

3c5cbc0

#492 get direct voltage model working

e678d23

#492 add discharge capacity as a variable with ODE

172f1ec

#492 updating current function and C-rate

a3b302e

#492 change solver times in examples

120178b

#492 fixing some tests

4238ad1

#492 fixing more tests and examples

194c707

#492 fix easy tests

2cd3f44

#492 debugging composite models

6e723a2

#492 flake8

b6393ee

#492 remove debug

8710f5e

#492 remove direct voltage control, too much effort

f113293

#492 clean up setting external variables for potentials

5f3bd18

#492 fix unit tests

7d156dd

#492 fixing integration tests and examples

e638b1b

#492 tests and coverage

7597712

valentinsulzer added 5 commits December 6, 2019 11:02

#492 merge master

2fd4883

#492 don't print casadi warnings in test

55c5e88

#492 fix composite

7eb60ec

#492 coverage for parameter values

c13d8b9

#492 change to casadi solver for broken test

fed0bbb

valentinsulzer requested review from rtimms and Scottmar93 December 7, 2019 22:12

rtimms approved these changes Dec 13, 2019

View reviewed changes

valentinsulzer added 4 commits December 13, 2019 08:33

#492 merge master

b3e0151

#492 rob comments

84867e1

#492 merge master

cee062c

#492 fix test

b54eb0e

valentinsulzer merged commit 2ca2598 into master Dec 14, 2019

valentinsulzer deleted the issue-492-potentiostatic branch December 14, 2019 02:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 492 potentiostatic #751

Issue 492 potentiostatic #751

valentinsulzer commented Nov 30, 2019

codecov bot commented Dec 4, 2019 •

edited

Loading

rtimms left a comment

rtimms Dec 13, 2019

valentinsulzer Dec 13, 2019

rtimms Dec 13, 2019

rtimms Dec 13, 2019

rtimms Dec 13, 2019

		from .base_external_circuit import BaseModel, LeadingOrderBaseModel


		class FunctionControl(BaseModel):

Issue 492 potentiostatic #751

Issue 492 potentiostatic #751

Conversation

valentinsulzer commented Nov 30, 2019

Description

Type of change

Key checklist:

Further checks:

codecov bot commented Dec 4, 2019 • edited Loading

Codecov Report

rtimms left a comment

Choose a reason for hiding this comment

rtimms Dec 13, 2019

Choose a reason for hiding this comment

valentinsulzer Dec 13, 2019

Choose a reason for hiding this comment

rtimms Dec 13, 2019

Choose a reason for hiding this comment

rtimms Dec 13, 2019

Choose a reason for hiding this comment

rtimms Dec 13, 2019

Choose a reason for hiding this comment

codecov bot commented Dec 4, 2019 •

edited

Loading