Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#655 dont check size on new copy #656

Merged
merged 2 commits into from
Oct 10, 2019
Merged

#655 dont check size on new copy #656

merged 2 commits into from
Oct 10, 2019

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Oct 10, 2019

Description

Don't unnecessarily check that the slice size exceeds the child size when making a new copy of an Index node

Fixes #655

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #656 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   98.49%   98.49%   +<.01%     
==========================================
  Files         167      167              
  Lines        8179     8180       +1     
==========================================
+ Hits         8056     8057       +1     
  Misses        123      123
Impacted Files Coverage Δ
pybamm/expression_tree/unary_operators.py 96.19% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de186a...2d89cc7. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @rtimms

@rtimms rtimms merged commit 2f76a8b into master Oct 10, 2019
@rtimms rtimms deleted the issue-655-index-copy branch October 10, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't get child.size when making new copy of Index
2 participants