-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup formatting in error messages #4565
Conversation
Out of lazy curiosity, is there a pre-commit hook that can clean things like these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing two mistakes
Probably, these just annoyed me when I was debugging something and it only took me a couple minutes to do it. I know there are a few |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4565 +/- ##
===========================================
- Coverage 99.42% 99.29% -0.14%
===========================================
Files 300 300
Lines 22774 22776 +2
===========================================
- Hits 22643 22615 -28
- Misses 131 161 +30 ☔ View full report in Codecov by Sentry. |
* Remove some unneeded links * Cleaning up some formatting * Update src/pybamm/discretisations/discretisation.py * Update src/pybamm/expression_tree/operations/convert_to_casadi.py
Description
I noticed some of the longer f-strings printed out with large indents. This PR is to clean that up a bit. There are still some triple quoted strings that could be cleaned up, but these are the easy ones to catch.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: