-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add sensitivities notebook #4559
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4559 +/- ##
========================================
Coverage 99.29% 99.29%
========================================
Files 300 300
Lines 22776 22776
========================================
Hits 22615 22615
Misses 161 161 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sort of indifferent to the google collab support since it adds a confusing install for local runs, but if we want to keep supporting that functionality then I think the notebook needs the pybamm install at the top
I forgot to mention, that I did not see any other issues with the notebook |
Thanks @kratman, are you happy to approve this now, or does anyone else want to do a review? (I'm happy to merge if not) |
* docs: add sensitivities notebook * docs: add sens notebook to toctree * add install line --------- Co-authored-by: Eric G. Kratz <[email protected]>
Description
Fixes #4558
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: