Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a type issue for windows #4486

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Oct 3, 2024

Description

This was an issue caught here: https://github.com/pybamm-team/pybammsolvers

In the standalone repo, wheels are built as part of the tests and were failing on windows. This fixed the issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman added the release blocker Issues that need to be addressed before the creation of a release label Oct 3, 2024
@kratman kratman self-assigned this Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.41%. Comparing base (444ecc1) to head (6f1acfd).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4486   +/-   ##
========================================
  Coverage    99.41%   99.41%           
========================================
  Files          293      293           
  Lines        22554    22554           
========================================
  Hits         22423    22423           
  Misses         131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratman kratman merged commit 2ca16ac into pybamm-team:develop Oct 3, 2024
26 checks passed
@kratman kratman deleted the fix/winTypeIssue branch October 3, 2024 15:19
pkalbhor pushed a commit to pkalbhor/PyBaMM that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release blocker Issues that need to be addressed before the creation of a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants