Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graded electrode example #4424

Merged
merged 5 commits into from
Sep 7, 2024
Merged

Graded electrode example #4424

merged 5 commits into from
Sep 7, 2024

Conversation

brosaplanella
Copy link
Member

@brosaplanella brosaplanella commented Sep 7, 2024

Description

Not related to any issue (sorry!), but I was asked how to simulate graded electrodes and realised we didn't have an example, so adding one here.

I kept it as a quite basic example, but if people have suggestions on other cases to study let me know.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.41%. Comparing base (ee325c7) to head (b3aeaf1).
Report is 202 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4424   +/-   ##
========================================
  Coverage    99.41%   99.41%           
========================================
  Files          292      292           
  Lines        22212    22212           
========================================
  Hits         22083    22083           
  Misses         129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valentinsulzer valentinsulzer merged commit 6c1815b into develop Sep 7, 2024
26 checks passed
@valentinsulzer valentinsulzer deleted the graded-electrode-example branch September 7, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants