-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove install_jax and rename have_jax #4362
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4362 +/- ##
===========================================
- Coverage 99.46% 99.42% -0.04%
===========================================
Files 289 289
Lines 22200 22153 -47
===========================================
- Hits 22081 22026 -55
- Misses 119 127 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kratman!
… fix/removeInstallJax
@Saransh-cpp, @agriyakhetarpal I pull out the has_jax() part for now |
Coverage failure is unrelated |
Part of the code under discussion was removed
Description
Removes the deprecated install_jax() method
Fixes #4131
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: