Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for mistakes found during the release process #4291

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Jul 24, 2024

Description

Minor fixes that are on develop, found during the release.

I also found some changelog errors, but I did those directly on the release branch and they will be addressed in a sync PR post-release.

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (ba39170) to head (b77a8cc).
Report is 211 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4291   +/-   ##
========================================
  Coverage    99.45%   99.45%           
========================================
  Files          288      288           
  Lines        22091    22091           
========================================
  Hits         21971    21971           
  Misses         120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratman kratman mentioned this pull request Jul 24, 2024
@kratman kratman marked this pull request as ready for review July 25, 2024 00:24
@kratman kratman merged commit 1d40956 into pybamm-team:develop Jul 25, 2024
26 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/releaseFindings branch July 25, 2024 14:32
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants