Code

Issue 4224 duration bug#4239

Code

Merged

kratman merged 14 commits intodeveloppybamm-team/PyBaMM:developfrom issue-4224-duration-bugpybamm-team/PyBaMM:issue-4224-duration-bugCopy head branch name to clipboardJul 11, 2024

+193-59

Commits

Commits on Jul 3, 2024

• make longer default duration and calculate it for C-rate

  valentinsulzer

  committed
  5c82389

  Copy full SHA for 5c82389

• add tests

  valentinsulzer

  committed
  20f9fd2

  Copy full SHA for 20f9fd2

• typo

  valentinsulzer

  committed
  b756ba8

  Copy full SHA for b756ba8

Commits on Jul 5, 2024

• #4224 add warning for time termination and add abs

  valentinsulzer

  committed
  05c6912

  Copy full SHA for 05c6912

• Merge branch 'develop' into issue-4224-duration-bug

  valentinsulzer

  committed
  f7fa90e

  Copy full SHA for f7fa90e

• Merge branch 'develop' into issue-4224-duration-bug

  valentinsulzer

  committed
  d738be9

  Copy full SHA for d738be9

• fix tests

  valentinsulzer

  committed
  1bc8d79

  Copy full SHA for 1bc8d79

Commits on Jul 9, 2024

• #4224 keep non-C-rate default at 24h for performance reasons

  valentinsulzer

  committed
  3a33836

  Copy full SHA for 3a33836

• Merge branch 'develop' into issue-4224-duration-bug

  valentinsulzer

  committed
  709fcf0

  Copy full SHA for 709fcf0

Commits on Jul 10, 2024

• trying to fix experiment

  valentinsulzer

  committed
  77ebe1c

  Copy full SHA for 77ebe1c

• Merge branch 'develop' into issue-4224-duration-bug

  valentinsulzer

  committed
  cdf2f43

  Copy full SHA for cdf2f43

• fix example

  valentinsulzer

  committed
  4808049

  Copy full SHA for 4808049

• #4224 eric comments

  valentinsulzer

  committed
  3ddf84c

  Copy full SHA for 3ddf84c

• fix bug

  valentinsulzer

  committed
  8381ba2

  Copy full SHA for 8381ba2