Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lychee issues from tinyurl #4219

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Jun 26, 2024

Description

Lychee was having issues with tinyurl, so this should avoid future issues.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this Jun 26, 2024
@kratman
Copy link
Contributor Author

kratman commented Jun 26, 2024

I will mark this as ready for review after I test that the links still work in the docs

@kratman
Copy link
Contributor Author

kratman commented Jun 26, 2024

While the tinyurl issues could be intermittent like some of the stack overflow ones, some of them also pointed to old documentation. So getting rid of the obfuscation is a plus

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (7ba74dc) to head (74381f7).
Report is 220 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4219      +/-   ##
===========================================
+ Coverage    99.54%   99.55%   +0.01%     
===========================================
  Files          288      288              
  Lines        21858    21856       -2     
===========================================
+ Hits         21758    21759       +1     
+ Misses         100       97       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valentinsulzer valentinsulzer merged commit e22d10c into pybamm-team:develop Jun 26, 2024
26 checks passed
@kratman kratman deleted the fix/tinyurl branch June 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants