Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included CMakeLists.txt #4101

Merged

Conversation

cringeyburger
Copy link
Contributor

Description

Current source distributions do not have the CMakelists.txt shipped in them, so the users cannot build it.
Fixed by adding CMakeLists.txt in Manifest.in

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

MANIFEST.in Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.54%. Comparing base (becb1a4) to head (20e1be6).
Report is 215 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4101      +/-   ##
===========================================
- Coverage    99.56%   99.54%   -0.02%     
===========================================
  Files          287      287              
  Lines        21744    21744              
===========================================
- Hits         21649    21646       -3     
- Misses          95       98       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@agriyakhetarpal agriyakhetarpal merged commit 0237b11 into pybamm-team:develop May 18, 2024
41 of 42 checks passed
@agriyakhetarpal
Copy link
Member

Thanks for the fix, @cringeyburger!

js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
* removed CMakeLists.txt from `exclude` in Manifest.in

---------

Co-authored-by: Agriya Khetarpal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants