Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing on Python 3.8, 3.9 for macOS arm64 #4041

Merged

Conversation

agriyakhetarpal
Copy link
Member

Description

See new releases at https://github.com/actions/python-versions/releases – Python 3.8 and Python 3.9 builds should be available for macOS arm64 (macos-14 tag) now.

xref: actions/setup-python#808

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (44d946f) to head (58f6630).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4041   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files          258      258           
  Lines        21310    21310           
========================================
  Hits         21223    21223           
  Misses          87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agriyakhetarpal
Copy link
Member Author

I think they are still not available right now, despite a new release for the Python versions. Converting to draft until we can see builds working for other repositories.

@agriyakhetarpal agriyakhetarpal marked this pull request as draft April 25, 2024 05:47
@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Apr 25, 2024

Should be working now, triggering a re-run

Edit: working and all tests pass. Ready for reviews and merging.

@agriyakhetarpal agriyakhetarpal marked this pull request as ready for review April 25, 2024 16:19
@kratman kratman merged commit 43ca3de into pybamm-team:develop Apr 26, 2024
41 of 42 checks passed
@agriyakhetarpal agriyakhetarpal deleted the enable-macos-14-python-versions branch April 26, 2024 14:57
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants