Remove RMSE function

[kratman]

Description

Minor removal of code and some cleanup of IDE warnings

Fixes #3982

Type of change

Removes old code

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (9fcd56b) to head (62fdd5f).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3988      +/-   ##
===========================================
- Coverage    99.58%   99.58%   -0.01%     
===========================================
  Files          257      257              
  Lines        21252    21242      -10     
===========================================
- Hits         21164    21154      -10     
  Misses          88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinsulzer]

All the code removed is fine. Please don't remove those comments. They add structure to the code and make it easier to scan. Removing the empty comment lines (# and nothing else) is fine.

[kratman]

All the code removed is fine. Please don't remove those comments. They add structure to the code and make it easier to scan. Removing the empty comment lines (# and nothing else) is fine.

I removed them because they basically all said something along the lines of

# functions from file X
from x import y

Which does not seem to add anything

[valentinsulzer]

It adds structure and makes the file easier to scan since they are highlighted in different colors by most IDEs

[Saransh-cpp]

Imports in pybamm's __init__.py file must be in a particular order (autoformatting tools usually mess up this order), so adding a structure with the comments makes sense.

[kratman]

It adds structure and makes the file easier to scan since they are highlighted in different colors by most IDEs

To me it did not add anything since it literally said what was right below that in the code, but I will add it back if you insist. In general my changes like this are just trying to clean up stuff that does not add anything like:

#
# Batch Study
#
from .batch_study import BatchStudy

which ends up adding a lot of comments for the exact thing that is below it.

Imports in pybamm's __init__.py file must be in a particular order (autoformatting tools usually mess up this order), so adding a structure with the comments makes sense.

I did not run any auto-formatting here and left the imports in groups. The only thing I did for my IDE was move the constants to the bottom of the file in order to stop the warnings about imports coming after code. The comments did not add any hints about which order things needed to be imported, no warnings about problematic stuff, etc. So I don't think they solve the import order problem either

However, the constants I moved look like they are not actually used and can probably be removed as well. PyBaMM triggers so many warnings in PyCharm that I often cannot see the real problems from the inspections. I try to clean up what I can as I work

[kratman]

Ok everything here is passing now besides Lychee