-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jax windows restrictions #3955
Jax windows restrictions #3955
Conversation
@agriyakhetarpal This should be all of the jax stuff. Since I am waiting on #3954 I will do the coverage fixes in a third PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry pushed another change after your review |
Coverage is still failing in #3954, so it will fail here too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the branch, it should be good to go now. Please feel free to merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3955 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 257 257
Lines 21196 21196
========================================
Hits 21108 21108
Misses 88 88 ☔ View full report in Codecov by Sentry. |
Based on the failing tests, I think the long-standing issue of Homebrew's We can remove OpenBLAS, though. It's not being used currently because we use Apple's Accelerate framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to trigger a re-run for some, but all tests pass now, we should be good to go. Thanks!
* Fix coverage * Remove windows Jax restrictions * style: pre-commit fixes * Update MacOS instructions * Update docs/source/user_guide/installation/install-from-source.rst * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Agriya Khetarpal <[email protected]>
Description
Restrictions on testing and installing Jax can be removed after #3550
Related: #3941
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: