Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original experiment protocol to coupled degradation example notebook #3689

Closed
wants to merge 14 commits into from

Conversation

DrSOKane
Copy link
Contributor

@DrSOKane DrSOKane commented Jan 4, 2024

Description

The experiment protocol for the coupled degradation example notebook was changed so that the 5 minute period applied to all stepts of all cycles, including the 1C discharge. This results in the simulation being unstable for large numbers of cycles. This pull request reverts the change and fixes the issue.

Fixes #3669

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d46cbe3) 99.59% compared to head (78f13f9) 99.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3689   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files          258      258           
  Lines        20796    20796           
========================================
  Hits         20711    20711           
  Misses          85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agriyakhetarpal
Copy link
Member

Hi @DrSOKane, could you switch to a new branch and recreate a new PR with these changes? This one is from the develop branch of your fork, which is not recommended to be good practice :)

@DrSOKane DrSOKane closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants