Fixed a bug where the SEI thickness decreased at some intervals when using the 'electron-migration limited' model.

[kawaMANMI]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

The SEI thickness decreased at some intervals when the 'electron-migration limited' model was used. It has been corrected by considering only negative contributions to eta_sei in the j_sei, using the Heaviside function.

Fixes #3613

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• [x ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (903323e) 99.59% compared to head (066c340) 99.59%.
Report is 257 commits behind head on develop.

❗ Current head 066c340 differs from pull request most recent head 3197432. Consider uploading reports for the commit 3197432 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3622   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files          258      258           
  Lines        20755    20755           
========================================
  Hits         20670    20670           
  Misses          85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brosaplanella]

I am happy with that, but been quite involved in the discussions with Kawa, so requesting other people to review it.

Changes applied

[brosaplanella]

We should add a CHANGELOG line about this, should we open a separate PR or should we revert this merge?

[brosaplanella]

@all-contributors please add @kawaMANMI for bug report and code

[allcontributors]

@brosaplanella

I've put up a pull request to add @kawaMANMI! 🎉

[kratman]

We should add a CHANGELOG line about this, should we open a separate PR or should we revert this merge?

@brosaplanella Sorry about that, I did not check for the change log. I would say just fix it in another PR. Reverting is messy